OK!...
Now I know I am no expert or even come close to it, but how do you find issues in my code?
Not to boost my ego or anything but I have been programming in Java pretty much since "Day 1", and consider my knowledge slightly above average than the regular newbie acceptable.
This week we were tasked with finding a person on slack to work with and I did just that, Chris - Bald (🦲) dude with a bad attitude. We had to fork, analyze and create new issues on their (Chris') repository.
OH BOY!
So I began forking, cloning, analyzing/ reviewing, fixing... the whole nice yards.
Chris did his 0.1 release on python EW. If you guys should know something about me, it is that I absolutely from the bottom of my heart despise python and anything built with python... but Chris looks like a smart dude and I figured looking at his code might not give me a brain aneurysm. P.S. it did not.
Anyways, it was time to begin. upon cloning his repo locally I began to read the README file he had provided with instructions on how to setup the tool and get it running. That is where I ran into the first issue. Since I hate python (as mentioned above) I had no idea which version I needed to install on my machine to get it running. I suggested he add a download link in the readme. The rest of the setup went pretty smooth.
Time to analyze
This was fun! Looking at how someone else handles the same exact problem is fascinating. Chris did a great job on his code, I did notice some exceptions that could be handled a little better but with my knowledge in python (basically none) I could not make a PR for that. Instead, I found something small that was confusing at first glance. His variable naming conventions, although fine for such a small tool, were not to my liking. So... I made what any other sensible person would have done. My first PR BABEEH. He actually merged it. I felt a sense of accomplishment, a sense of contribution.
Likewise, Chris found several issues on my 0.1 release. They were not anything ground breaking but he did help me clean up my code a bit. He edited my instructional README quite a lot, which was a punch in the gut I thought was clear enough but with the edits it looks and sounds more clear. Thanks bud.
All in all, this experience with communicating, reviewing, and fixing other's "mistakes" was a very insightful experience on how the real world operates.
Chris was an awesome partner and I agree with his words (some) "We Learned", however I would say...
We didn't grow, We didn't laugh, I definitely hate him.
Till later,
XOXO,
Gossip Plamen
P.S. I don't actually hate you that much Chris
No comments:
Post a Comment